Update nscplugin, sbt-scala-native to 0.5.1 #4585

typelevel-steward · 2024-04-16T16:05:55Z

About this PR

📦 Updates

from 0.4.17 to 0.5.1

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-native" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-native" }
}]

^{labels: library-update, early-semver-major, semver-spec-minor, commit-count:1}

satorg · 2024-04-18T07:33:12Z

Seems blocked by typelevel/discipline#446,

satorg · 2024-05-01T18:23:12Z

+ Update scalacheck to 1.18.0
+ Update discipline-core to 1.7.0
+ Update discipline-munit to 2.0.0-M4

satorg · 2024-05-02T02:57:22Z

Ok, the checks are passing now 🎉
@armanbilge @mpilquist could you verify that tlVersionIntroduced and other settings are properly re-aligned here in the PR please? Thank you!

armanbilge · 2024-05-10T16:31:31Z

Can we take a pass through the project and remove all the weird stuff we did b/c Scala Native didn't support multi-threading? For example this should no longer be necessary:

cats/tests/native/src/test/scala/cats/native/tests/FutureSuite.scala

Lines 40 to 41 in dfd9559

    
           // TODO: We shouldn't do this! See: https://github.com/scala-js/scala-js/issues/2102 
        
           implicit private object SynchronousExecutor extends ExecutionContextExecutor {

Probably we can now share that suite between JVM and Native.

Thanks!

A special synchronous executor for scala-native is no longer needed for FutureSuite as scala-native 0.5.x is multi-threaded. FutureSuite is now shared between JVM and Native.

kapunga · 2024-05-12T14:20:15Z

Can we take a pass through the project and remove all the weird stuff we did b/c Scala Native didn't support multi-threading? For example this should no longer be necessary:

cats/tests/native/src/test/scala/cats/native/tests/FutureSuite.scala

Lines 40 to 41 in dfd9559

// TODO: We shouldn't do this! See: https://github.com/scala-js/scala-js/issues/2102

implicit private object SynchronousExecutor extends ExecutionContextExecutor {

Probably we can now share that suite between JVM and Native.

Thanks!

Wasn't sure if anyone was working on this so I went ahead and opened a PR: #4601

Remove special ExecutionContextExecutor

danicheg

CI is constantly failing with

[error] Test runner interrupted by fatal signal 11
[warn] Force close java.lang.RuntimeException: Process /home/runner/work/cats/cats/tests/native/target/scala-2.13/cats-tests-test finished with non-zero value 139 (0x8b)

mzuehlke · 2024-05-24T19:42:18Z

build.sbt


-val disciplineMunitVersion = "2.0.0-M3"
+val disciplineMunitVersion = "2.0.0-M4"


In the meantime there is a 2.0.0 release: https://github.com/typelevel/discipline-munit/releases/tag/v2.0.0

That's right. However, I think it wouldn't hurt if we address it in a separate PR to avoid stuffing up this one.

It would be perfect, if @typelevel-steward could wake up and create such a PR for us.

danicheg · 2024-05-25T06:15:08Z

Shall we publish a fresh release?

mpilquist · 2024-05-25T13:49:04Z

@armanbilge and I were discussing a release plan yesterday on Discord. He suggested a Cats 2.11.0 release against Native 0.4 and then an immediate Cats 2.12.0 release against Native 0.5. To do so, we'll have to temporarily downgrade native on main branch.

armanbilge · 2024-05-25T16:01:53Z

To do so, we'll have to temporarily downgrade native on main branch.

Not necessarily. We can tag 3c7474b (the commit prior to merging this PR) as v2.11.0. The v2.11.0 release will be missing any PRs that were merged after, such as #4602.

satorg · 2024-05-25T16:18:24Z

The v2.11.0 release will be missing any PRs that were merged after

Actually, there were exactly two of them:

Update discipline-munit to 2.0.0 #4605 followed by
Add flatMapOrKeep to Monad #4602

armanbilge · 2024-05-25T16:24:58Z

Right, but #4605 would be unable to land in v2.11.0 anyway :)

sideeffffect · 2024-06-01T08:53:53Z

Hello good people here, may I ask what did you do to fix/workaround the problem with

finished with non-zero value 139

#4585 (review)
?

Trying to follow the approach taken in typelevel/cats#4585

* Update scala-library to 2.13.14 * Update cats to 2.12.0 * Update scala-native to 0.5.4 * Update munit deps to 1.0.0 * Fix munit deps for Scala 2.11 * Fix build.sbt formatting * Fix repeated naming warning / error * Reset tlVersionIntroduced for Scala Native 0.5 Trying to follow the approach taken in typelevel/cats#4585

typelevel-steward bot mentioned this pull request Apr 16, 2024

Update nscplugin, sbt-scala-native to 0.5.0 #4584

Closed

mpilquist linked an issue Apr 17, 2024 that may be closed by this pull request

Support Scala Native 0.5 #4587

Closed

MateuszKubuszok mentioned this pull request Apr 25, 2024

Update nscplugin, sbt-scala-native to 0.5.0 scalalandio/chimney#501

Closed

satorg force-pushed the update/nscplugin-0.5.1 branch from 8d98033 to e383012 Compare May 1, 2024 18:21

typelevel-steward bot and others added 6 commits May 1, 2024 17:21

Update nscplugin, sbt-scala-native to 0.5.1

038772c

Update discipline-munit to 2.0.0-M4

9162bd8

Update scalacheck to 1.18.0

f03a443

Update discipline-core to 1.7.0

ac3d1b0

Apply sbt githubWorkflowGenerate

3660c1c

fix tlVersionIntroduced for native cross-projects

a4068f4

satorg force-pushed the update/nscplugin-0.5.1 branch from 8e829ea to a4068f4 Compare May 2, 2024 00:22

satorg requested review from armanbilge and mpilquist May 2, 2024 02:57

satorg mentioned this pull request May 5, 2024

Support Scala Native 0.5 #4587

Closed

Remove special ExecutionContextExecutor

ea519d4

A special synchronous executor for scala-native is no longer needed for FutureSuite as scala-native 0.5.x is multi-threaded. FutureSuite is now shared between JVM and Native.

mpilquist previously approved these changes May 13, 2024

View reviewed changes

Merge pull request #4601 from kapunga/update/cleanup-native

07dad69

Remove special ExecutionContextExecutor

armanbilge dismissed mpilquist’s stale review via 07dad69 May 13, 2024 19:30

mpilquist mentioned this pull request May 13, 2024

Update to scala-native 0.5.1 typelevel/twiddles#35

Merged

mpilquist approved these changes May 13, 2024

View reviewed changes

hamnis mentioned this pull request May 14, 2024

Update nscplugin, sbt-scala-native to 0.5.4 circe/circe#2254

Merged

danicheg reviewed May 19, 2024

View reviewed changes

mpilquist mentioned this pull request May 24, 2024

Update nscplugin, sbt-scala-native to 0.5.1 typelevel/scalacheck-effect#348

Closed

Merge branch 'main' into update/nscplugin-0.5.1

5fd3703

mzuehlke reviewed May 24, 2024

View reviewed changes

satorg approved these changes May 24, 2024

View reviewed changes

mzuehlke approved these changes May 24, 2024

View reviewed changes

satorg merged commit 6529b30 into main May 25, 2024
17 checks passed

satorg deleted the update/nscplugin-0.5.1 branch May 25, 2024 01:18

MateuszKubuszok mentioned this pull request Jun 1, 2024

Scala Native 0.5.x cquiroz/scala-java-time#508

Merged

valencik added a commit to valencik/cats-parse that referenced this pull request Jul 31, 2024

Reset tlVersionIntroduced for Scala Native 0.5

0501613

Trying to follow the approach taken in typelevel/cats#4585

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update nscplugin, sbt-scala-native to 0.5.1 #4585

Update nscplugin, sbt-scala-native to 0.5.1 #4585

typelevel-steward bot commented Apr 16, 2024

satorg commented Apr 18, 2024

satorg commented May 1, 2024

satorg commented May 2, 2024

armanbilge commented May 10, 2024

kapunga commented May 12, 2024

danicheg left a comment

mzuehlke May 24, 2024

satorg May 24, 2024

danicheg commented May 25, 2024

mpilquist commented May 25, 2024

armanbilge commented May 25, 2024

satorg commented May 25, 2024

armanbilge commented May 25, 2024 •

edited

Loading

sideeffffect commented Jun 1, 2024


		val disciplineMunitVersion = "2.0.0-M3"
		val disciplineMunitVersion = "2.0.0-M4"

Update nscplugin, sbt-scala-native to 0.5.1 #4585

Update nscplugin, sbt-scala-native to 0.5.1 #4585

Conversation

typelevel-steward bot commented Apr 16, 2024

About this PR

Usage

satorg commented Apr 18, 2024

satorg commented May 1, 2024

satorg commented May 2, 2024

armanbilge commented May 10, 2024

kapunga commented May 12, 2024

danicheg left a comment

Choose a reason for hiding this comment

mzuehlke May 24, 2024

Choose a reason for hiding this comment

satorg May 24, 2024

Choose a reason for hiding this comment

danicheg commented May 25, 2024

mpilquist commented May 25, 2024

armanbilge commented May 25, 2024

satorg commented May 25, 2024

armanbilge commented May 25, 2024 • edited Loading

sideeffffect commented Jun 1, 2024

armanbilge commented May 25, 2024 •

edited

Loading